clickable/touchable area distinct from displayed element#4
Open
ccoenen wants to merge 4 commits intodirkweber:masterfrom
Open
clickable/touchable area distinct from displayed element#4ccoenen wants to merge 4 commits intodirkweber:masterfrom
ccoenen wants to merge 4 commits intodirkweber:masterfrom
Conversation
when the element is orthogonal to the display plane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch enables specifying your own "mouse-down-element". We had a bug where we could hardly rotate the ball, when it was orthogonal to the display pane. Specifying another element (which is not rotated) fixes this. In our project, we actually use the same element as config.stage, but we felt it would be better to keep it flexible. The change is contained in commit c550317, the other ones are just "the path there".